fix: add reasoning_content field to fix pydantic validation error - #92
Open
mwien wants to merge 2 commits into
Open
fix: add reasoning_content field to fix pydantic validation error#92mwien wants to merge 2 commits into
mwien wants to merge 2 commits into
Conversation
mwien
force-pushed
the
orchestration-reasoning-content
branch
from
August 27, 2026 12:19
b0fdb49 to
9204c29
Compare
Author
|
Added some minimal unit testing for now, previousy there was no unit testing for ChatResponseMessage unless I missed something. So maybe in a separate PR more testing can be added. Changelog: where should I log the changes? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A minimal fix to avoid Pydantic validation errors in case reasoning content is returned in the orchestration response. Later we should add convenience functionalities around reasoning content, but this is a larger project and imo out-of-scope of this fix PR.
I quickly checked manually that this fixes the issue. We should likely add some e2e/integration tests to ensure correctness (but those have been flaky recently). In case this PR is not urgent I can take care of this before merging.